Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(HorizontalScroll): remove inline prop #7582

Merged
merged 6 commits into from
Sep 19, 2024
Merged

feat(HorizontalScroll): remove inline prop #7582

merged 6 commits into from
Sep 19, 2024

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented Sep 13, 2024 •
edited
Loading

  • e2e-тесты
  • Release notes

Описание

Удаляем inline проп, потому что HorizontalScroll подразумевает, что контент будет располагаться горизонтально без дополнительных оберток.

Изменения

Убрала все использования inline- пропа или использование оберток из документации.

⚠️ Вызывает сомнение теперь актуальность пропа compensateLastCellIndent у HorizontalCellShowMore. Может, удалим? Какая может быть необходимость не размещать на одном уровне с остальными ячейками "Показать всё"?

Release notes

BREAKING CHANGE

  • HorizontalScroll: свойство inline удалено и теперь применяется по умолчанию. Если вы использовали дополнительные обертки, чтобы выравнивать ячейки внутри компонента, просьба пересмотреть их использование.

  • HorizontalCellShowMore: свойство compensateLastCellIndent удалено. Если вы использовали дополнительные обертки внутри HorizontalScroll, чтобы выравнивать ячейки внутри компонента, просьба пересмотреть их использование и размещать HorizontalCellShowMore на том же уровне вложенности, что и остальные ячейки в HorizontalScroll

@BlackySoul BlackySoul requested a review from a team as a code owner September 13, 2024 16:40
@BlackySoul BlackySoul marked this pull request as draft September 13, 2024 16:41
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 13, 2024 •
edited
Loading

size-limit report 📦

Path Size
JS 385.35 KB (-0.05% 🔽)
JS (gzip) 116.51 KB (-0.06% 🔽)
JS (brotli) 95.63 KB (-0.15% 🔽)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 330.62 KB (-0.07% 🔽)
CSS (gzip) 41.36 KB (-0.09% 🔽)
CSS (brotli) 32.81 KB (-0.16% 🔽)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Sep 13, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 13, 2024 •
edited
Loading

e2e tests

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 13, 2024 •
edited
Loading

👀 Docs deployed

Commit b9f76fa

@codecov Codecov
Copy link

codecov bot commented Sep 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.20%. Comparing base (f676e88) to head (b9f76fa).
Report is 10 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7582      +/-   ##
==========================================
- Coverage   95.20%   95.20%   -0.01%     
==========================================
  Files         384      384              
  Lines       11354    11351       -3     
  Branches     3726     3723       -3     
==========================================
- Hits        10810    10807       -3     
  Misses        544      544
Flag Coverage Δ
unittests 95.20% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul marked this pull request as ready for review September 16, 2024 04:51
@andrey-medvedev-vk
Copy link
Contributor

⚠️ Вызывает сомнение теперь актуальность пропа compensateLastCellIndent у HorizontalCellShowMore. Может, удалим? Какая может быть необходимость не размещать на одном уровне с остальными ячейками "Показать всё"

Да, раз в HorizontalCell используется псевдокласс :last-type для задания отступа справа, то можно и у HorizontalCellShowMore убрать проп compensateLastCellIndent, который нужен лишь для того, чтобы компенсировать отступ HorizontalCell, если HorizontalCell находятся внутри какой-то обертки (не на одном уровне с HorizontalCellShowMore)

Но, тогда надо явно прописать правило, что HorizontalCell и HorizontalCellShowMore должны быть на одном уровне.

andrey-medvedev-vk
andrey-medvedev-vk previously approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

packages/codemods/src/transforms/v7/horizontal-scroll.ts Outdated Show resolved Hide resolved
@BlackySoul BlackySoul self-assigned this Sep 16, 2024
@BlackySoul BlackySoul added this to the v7.0.0-beta.0 milestone Sep 16, 2024
inomdzhon
inomdzhon previously approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

andrey-medvedev-vk
andrey-medvedev-vk previously approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

inomdzhon
inomdzhon previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

конлфикт(

@BlackySoul BlackySoul force-pushed the blackysoul/HorizontalScroll_inline_prop branch from 89fdc5b to c9ba93a Compare September 17, 2024 15:48
inomdzhon
inomdzhon previously approved these changes Sep 17, 2024
View reviewed changes
andrey-medvedev-vk
andrey-medvedev-vk approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@BlackySoul BlackySoul merged commit 7460804 into master Sep 19, 2024
28 checks passed
@BlackySoul BlackySoul deleted the blackysoul/HorizontalScroll_inline_prop branch September 19, 2024 13:07
@vkcom-publisher
Copy link
Contributor

✅ v7.0.0-beta.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-medvedev-vk andrey-medvedev-vk andrey-medvedev-vk approved these changes

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees

@BlackySoul BlackySoul

Labels
breaking-change cmp:horizontal-cell-show-more cmp:horizontal-scroll
Projects
VKUI
Archived in project
Milestone
v7.0.0-beta.0
Development

Successfully merging this pull request may close these issues.
4 participants
@BlackySoul @andrey-medvedev-vk @vkcom-publisher @inomdzhon